Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCE/GKE proxy mentioned for Azure #2717

Merged
merged 1 commit into from
Jun 27, 2018
Merged

GCE/GKE proxy mentioned for Azure #2717

merged 1 commit into from
Jun 27, 2018

Conversation

dsalamancaMS
Copy link
Contributor

GCE/GKE are part of Google cloud not azure, so the note "proxy protocol is not supported in GCE/GKE" does not apply for azure

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@dsalamancaMS
GCE/GKE proxy mentioned for Azure
fc14365 
GCE/GKE are part of Google cloud not azure, so the note "proxy protocol is not supported in GCE/GKE" does not apply for azure
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2018
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 27, 2018
@dsalamancaMS
Copy link
Contributor Author

Signed the CLA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 27, 2018
@dsalamancaMS
Copy link
Contributor Author

/assign @ElvinEfendi

@aledbf
Copy link
Member

aledbf commented Jun 27, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, dsalamancaMS

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2018
@aledbf
Copy link
Member

aledbf commented Jun 27, 2018

GCE/GKE are part of Google cloud not azure

Apologies for this terrible mistake in the docs.

@aledbf
Copy link
Member

aledbf commented Jun 27, 2018

@dsalamancaMS thanks!

@aledbf
Copy link
Member

aledbf commented Jun 27, 2018

Merging.

@aledbf aledbf merged commit 29c5d77 into kubernetes:master Jun 27, 2018
@codecov-io
Copy link

Codecov Report

Merging #2717 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2717   +/-   ##
=======================================
  Coverage   40.95%   40.95%           
=======================================
  Files          72       72           
  Lines        5084     5084           
=======================================
  Hits         2082     2082           
  Misses       2713     2713           
  Partials      289      289

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd0ee62...fc14365. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

@ElvinEfendi ElvinEfendi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dsalamancaMS @k8s-ci-robot @aledbf @codecov-io @ElvinEfendi